core/src/fxge/agg/src/fx_agg_driver.cpp - Issue 1243883003: Fix else-after-returns throughout pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/agg/src/fx_agg_driver.cpp

Issue 1243883003: Fix else-after-returns throughout pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/agg/src/fx_agg_driver.cpp

diff --git a/core/src/fxge/agg/src/fx_agg_driver.cpp b/core/src/fxge/agg/src/fx_agg_driver.cpp

index 475e5f6442412c22fc27dda8b43b9ecb34e62ad7..118db7bf1fac8e9a377ee75cf4d805672017c5f5 100644

--- a/core/src/fxge/agg/src/fx_agg_driver.cpp

+++ b/core/src/fxge/agg/src/fx_agg_driver.cpp

@@ -417,7 +417,8 @@ public:

}

return;

- } else if (Bpp == 3 || Bpp == 4) {

+ }

+ if (Bpp == 3 || Bpp == 4) {

for (int col = col_start; col < col_end; col ++) {

int src_alpha;

if (clip_scan) {

@@ -479,7 +480,8 @@ public:

}

return;

- } else if (Bpp == 3 || Bpp == 4) {

+ }

+ if (Bpp == 3 || Bpp == 4) {

for (int col = col_start; col < col_end; col ++) {

int src_alpha;

if (clip_scan) {

@@ -508,7 +510,8 @@ public:

continue;

}

return;

- } else if (Bpp == 1) {

+ }

+ if (Bpp == 1) {

for (int col = col_start; col < col_end; col ++) {

int src_alpha;

if (clip_scan) {

« no previous file with comments | « core/src/fxcrt/fx_basic_wstring.cpp ('k') | core/src/fxge/dib/fx_dib_composite.cpp » ('j') | no next file with comments »