core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp - Issue 1243883003: Fix else-after-returns throughout pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

Issue 1243883003: Fix else-after-returns throughout pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

index 0471250fd958c309477af1713daa4e33e2d23323..f630ea52da9f16d5d41bfcb319705f3a34c9a6c1 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp

@@ -181,10 +181,9 @@ CFX_WideString FPDF_FileSpec_GetWin32Path(const CPDF_Object* pFileSpec)

result += ':';

result += ChangeSlash(wsFileName.c_str() + 2);

return result;

- } else {

- CFX_WideString result;

- result += '\\';

- result += ChangeSlash(wsFileName.c_str());

- return result;

}

+ CFX_WideString result;

+ result += '\\';

+ result += ChangeSlash(wsFileName.c_str());

+ return result;

}