Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1243853002: Move chrome/browser/chromeos/drive/drive.proto into components/drive (Closed)

Created:
5 years, 5 months ago by Łukasz Anforowicz
Modified:
5 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, tfarina, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, mtomasz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move chrome/browser/chromeos/drive/drive.proto into components/drive Changes of include paths under chrome/browser/chromeos/extensions are purely mechanical and therefore I am using tbr for them. TBR=kalman@chromium.org BUG=257943, 498951 Committed: https://crrev.com/01b9d55a31083aa9d48b9fc2e85cbc4038623a9e Cr-Commit-Position: refs/heads/master@{#339653}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -244 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/download_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/drive/drive.proto View 1 chunk +0 lines, -170 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_change.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/set_property_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/set_property_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/touch_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_core_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/remove_stale_cache_files.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/api_registration.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 3 chunks +1 line, -13 lines 0 comments Download
M components/drive.gypi View 2 chunks +14 lines, -0 lines 0 comments Download
M components/drive/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
A + components/drive/drive.proto View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Łukasz Anforowicz
Ryo, could you please take a look?
5 years, 5 months ago (2015-07-20 23:42:47 UTC) #3
hashimoto
lgtm
5 years, 5 months ago (2015-07-21 10:59:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243853002/20001
5 years, 5 months ago (2015-07-21 15:14:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-21 15:19:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/01b9d55a31083aa9d48b9fc2e85cbc4038623a9e Cr-Commit-Position: refs/heads/master@{#339653}
5 years, 5 months ago (2015-07-21 15:20:43 UTC) #8
hashimoto
5 years, 5 months ago (2015-07-22 04:50:41 UTC) #10
Message was sent while issue was closed.
Just FTR.
Next time when using TBR, could you add the person who is TBRed to the reviewers
list so that they can receive a mail notification?
Without it, the TBRed person has no chance to notice what's happening.

Powered by Google App Engine
This is Rietveld 408576698