Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 124383008: Remove is_prerender() from ChromeURLRequestUserData since it's not used anymore. (Closed)

Created:
6 years, 11 months ago by jam
Modified:
6 years, 11 months ago
Reviewers:
davidben
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Remove is_prerender() from ChromeURLRequestUserData since it's not used anymore. Also remove ChromeURLRequestUserData since no one else is using it. BUG=304341 R=davidben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243366

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -88 lines) Patch
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_url_request_user_data.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/renderer_host/chrome_url_request_user_data.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_throttle.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years, 11 months ago (2014-01-06 22:32:12 UTC) #1
davidben
LGTM, although do we want to just punt ChromeURLRequestUserData altogether now? I don't see anywhere ...
6 years, 11 months ago (2014-01-06 22:45:49 UTC) #2
jam
On 2014/01/06 22:45:49, David Benjamin wrote: > LGTM, although do we want to just punt ...
6 years, 11 months ago (2014-01-06 22:53:50 UTC) #3
davidben
6 years, 11 months ago (2014-01-06 23:01:34 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698