Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: gdb/annotate.c

Issue 124383005: GDB 7.6.50 (Closed) Base URL: http://git.chromium.org/native_client/nacl-gdb.git@upstream
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gdb/annotate.h ('k') | gdb/arch-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gdb/annotate.c
diff --git a/gdb/annotate.c b/gdb/annotate.c
index cd0a94aedaf0c2aaba2869df6e7cecf4abf6899d..ccba5fe67a1e0bfdcc595eaa576df375256ddbc9 100644
--- a/gdb/annotate.c
+++ b/gdb/annotate.c
@@ -1,6 +1,5 @@
/* Annotation routines for GDB.
- Copyright (C) 1986, 1989-1992, 1994-1996, 1998-2000, 2007-2012 Free
- Software Foundation, Inc.
+ Copyright (C) 1986-2013 Free Software Foundation, Inc.
This file is part of GDB.
@@ -24,6 +23,7 @@
#include "gdbtypes.h"
#include "breakpoint.h"
#include "observer.h"
+#include "inferior.h"
/* Prototypes for local functions. */
@@ -38,7 +38,22 @@ static void breakpoint_changed (struct breakpoint *b);
void (*deprecated_annotate_signalled_hook) (void);
void (*deprecated_annotate_signal_hook) (void);
-static int ignore_count_changed = 0;
+/* Booleans indicating whether we've emitted certain notifications.
+ Used to suppress useless repeated notifications until the next time
+ we're ready to accept more commands. Reset whenever a prompt is
+ displayed. */
+static int frames_invalid_emitted;
+static int breakpoints_invalid_emitted;
+
+/* True if the target can async, and a synchronous execution command
+ is not in progress. If true, input is accepted, so don't suppress
+ annotations. */
+
+static int
+async_background_execution_p (void)
+{
+ return (target_can_async_p () && !sync_execution);
+}
static void
print_value_flags (struct type *t)
@@ -48,32 +63,20 @@ print_value_flags (struct type *t)
else
printf_filtered (("-"));
}
-
-void
-breakpoints_changed (void)
+
+static void
+annotate_breakpoints_invalid (void)
{
- if (annotation_level == 2)
+ if (annotation_level == 2
+ && (!breakpoints_invalid_emitted
+ || async_background_execution_p ()))
{
target_terminal_ours ();
printf_unfiltered (("\n\032\032breakpoints-invalid\n"));
- if (ignore_count_changed)
- ignore_count_changed = 0; /* Avoid multiple break annotations. */
+ breakpoints_invalid_emitted = 1;
}
}
-/* The GUI needs to be informed of ignore_count changes, but we don't
- want to provide successive multiple breakpoints-invalid messages
- that are all caused by the fact that the ignore count is changing
- (which could keep the GUI very busy). One is enough, after the
- target actually "stops". */
-
-void
-annotate_ignore_count_change (void)
-{
- if (annotation_level > 1)
- ignore_count_changed = 1;
-}
-
void
annotate_breakpoint (int num)
{
@@ -107,11 +110,6 @@ annotate_stopped (void)
{
if (annotation_level > 1)
printf_filtered (("\n\032\032stopped\n"));
- if (annotation_level > 1 && ignore_count_changed)
- {
- ignore_count_changed = 0;
- breakpoints_changed ();
- }
}
void
@@ -207,10 +205,13 @@ annotate_breakpoints_table_end (void)
void
annotate_frames_invalid (void)
{
- if (annotation_level == 2)
+ if (annotation_level == 2
+ && (!frames_invalid_emitted
+ || async_background_execution_p ()))
{
target_terminal_ours ();
printf_unfiltered (("\n\032\032frames-invalid\n"));
+ frames_invalid_emitted = 1;
}
}
@@ -560,18 +561,30 @@ annotate_array_section_end (void)
printf_filtered (("\n\032\032array-section-end\n"));
}
+/* Called when GDB is about to display the prompt. Used to reset
+ annotation suppression whenever we're ready to accept new
+ frontend/user commands. */
+
+void
+annotate_display_prompt (void)
+{
+ frames_invalid_emitted = 0;
+ breakpoints_invalid_emitted = 0;
+}
+
static void
breakpoint_changed (struct breakpoint *b)
{
- breakpoints_changed ();
+ if (b->number <= 0)
+ return;
+
+ annotate_breakpoints_invalid ();
}
void
_initialize_annotate (void)
{
- if (annotation_level == 2)
- {
- observer_attach_breakpoint_deleted (breakpoint_changed);
- observer_attach_breakpoint_modified (breakpoint_changed);
- }
+ observer_attach_breakpoint_created (breakpoint_changed);
+ observer_attach_breakpoint_deleted (breakpoint_changed);
+ observer_attach_breakpoint_modified (breakpoint_changed);
}
« no previous file with comments | « gdb/annotate.h ('k') | gdb/arch-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698