Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Side by Side Diff: runtime/vm/assembler_x64.h

Issue 12438032: Use shorter write-barrier filtering sequence when value is known to be non-smi. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Ivan's comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_X64_H_ 5 #ifndef VM_ASSEMBLER_X64_H_
6 #define VM_ASSEMBLER_X64_H_ 6 #define VM_ASSEMBLER_X64_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_x64.h directly; use assembler.h instead. 9 #error Do not include assembler_x64.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 void incl(const Address& address); 526 void incl(const Address& address);
527 void decl(const Address& address); 527 void decl(const Address& address);
528 528
529 void incq(Register reg); 529 void incq(Register reg);
530 void incq(const Address& address); 530 void incq(const Address& address);
531 void decq(Register reg); 531 void decq(Register reg);
532 void decq(const Address& address); 532 void decq(const Address& address);
533 533
534 void negl(Register reg); 534 void negl(Register reg);
535 void negq(Register reg); 535 void negq(Register reg);
536 void notl(Register reg);
536 void notq(Register reg); 537 void notq(Register reg);
537 538
538 void enter(const Immediate& imm); 539 void enter(const Immediate& imm);
539 void leave(); 540 void leave();
540 void ret(); 541 void ret();
541 542
542 void movmskpd(Register dst, XmmRegister src); 543 void movmskpd(Register dst, XmmRegister src);
543 void movmskps(Register dst, XmmRegister src); 544 void movmskps(Register dst, XmmRegister src);
544 545
545 void sqrtsd(XmmRegister dst, XmmRegister src); 546 void sqrtsd(XmmRegister dst, XmmRegister src);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 626
626 void LoadObject(Register dst, const Object& object); 627 void LoadObject(Register dst, const Object& object);
627 void StoreObject(const Address& dst, const Object& obj); 628 void StoreObject(const Address& dst, const Object& obj);
628 void PushObject(const Object& object); 629 void PushObject(const Object& object);
629 void CompareObject(Register reg, const Object& object); 630 void CompareObject(Register reg, const Object& object);
630 void LoadDoubleConstant(XmmRegister dst, double value); 631 void LoadDoubleConstant(XmmRegister dst, double value);
631 632
632 // Destroys value. 633 // Destroys value.
633 void StoreIntoObject(Register object, // Object we are storing into. 634 void StoreIntoObject(Register object, // Object we are storing into.
634 const Address& dest, // Where we are storing into. 635 const Address& dest, // Where we are storing into.
635 Register value); // Value we are storing. 636 Register value, // Value we are storing.
637 bool can_value_be_smi = true);
636 638
637 void StoreIntoObjectNoBarrier(Register object, 639 void StoreIntoObjectNoBarrier(Register object,
638 const Address& dest, 640 const Address& dest,
639 Register value); 641 Register value);
640 642
641 void DoubleNegate(XmmRegister d); 643 void DoubleNegate(XmmRegister d);
642 void FloatNegate(XmmRegister f); 644 void FloatNegate(XmmRegister f);
643 645
644 void DoubleAbs(XmmRegister reg); 646 void DoubleAbs(XmmRegister reg);
645 647
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
814 void EmitComplex(int rm, const Operand& operand, const Immediate& immediate); 816 void EmitComplex(int rm, const Operand& operand, const Immediate& immediate);
815 void EmitLabel(Label* label, int instruction_size); 817 void EmitLabel(Label* label, int instruction_size);
816 void EmitLabelLink(Label* label); 818 void EmitLabelLink(Label* label);
817 void EmitNearLabelLink(Label* label); 819 void EmitNearLabelLink(Label* label);
818 820
819 void EmitGenericShift(bool wide, int rm, Register reg, const Immediate& imm); 821 void EmitGenericShift(bool wide, int rm, Register reg, const Immediate& imm);
820 void EmitGenericShift(bool wide, int rm, Register operand, Register shifter); 822 void EmitGenericShift(bool wide, int rm, Register operand, Register shifter);
821 823
822 void StoreIntoObjectFilter(Register object, Register value, Label* no_update); 824 void StoreIntoObjectFilter(Register object, Register value, Label* no_update);
823 825
826 // Shorter filtering sequence that assumes that value is not a smi.
827 void StoreIntoObjectFilterNoSmi(Register object,
828 Register value,
829 Label* no_update);
830
824 DISALLOW_ALLOCATION(); 831 DISALLOW_ALLOCATION();
825 DISALLOW_COPY_AND_ASSIGN(Assembler); 832 DISALLOW_COPY_AND_ASSIGN(Assembler);
826 }; 833 };
827 834
828 835
829 inline void Assembler::EmitUint8(uint8_t value) { 836 inline void Assembler::EmitUint8(uint8_t value) {
830 buffer_.Emit<uint8_t>(value); 837 buffer_.Emit<uint8_t>(value);
831 } 838 }
832 839
833 840
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 } 904 }
898 905
899 906
900 inline void Assembler::EmitOperandSizeOverride() { 907 inline void Assembler::EmitOperandSizeOverride() {
901 EmitUint8(0x66); 908 EmitUint8(0x66);
902 } 909 }
903 910
904 } // namespace dart 911 } // namespace dart
905 912
906 #endif // VM_ASSEMBLER_X64_H_ 913 #endif // VM_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698