Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1243773003: cc: Add a resource_provider_ dcheck in resource_pool creation. (Closed)

Created:
5 years, 5 months ago by vmpstr
Modified:
5 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add a resource_provider_ dcheck in resource_pool creation. This patch just adds one DCHECK in order to help diagnose a crash that seems to happen when we create a resource_pool with a null resource provider. R=enne BUG=419086 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7baed6836b25569063305363e9c6f7b7169853e1 Cr-Commit-Position: refs/heads/master@{#339747}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vmpstr
Please take a look.
5 years, 5 months ago (2015-07-20 23:17:13 UTC) #1
enne (OOO)
Should this be a temporary CRASH if you're trying to diagnose this?
5 years, 5 months ago (2015-07-20 23:20:41 UTC) #2
vmpstr
PTAL
5 years, 5 months ago (2015-07-21 17:24:18 UTC) #3
enne (OOO)
lgtm
5 years, 5 months ago (2015-07-21 19:04:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243773003/40001
5 years, 5 months ago (2015-07-21 19:49:13 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-21 21:12:08 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:13:05 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7baed6836b25569063305363e9c6f7b7169853e1
Cr-Commit-Position: refs/heads/master@{#339747}

Powered by Google App Engine
This is Rietveld 408576698