Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: content/browser/tracing/background_tracing_manager_impl.h

Issue 1243743002: Slow Reports - Add message filter to trigger background traces from child processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed dcheng's comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/tracing_messages.h ('k') | content/browser/tracing/background_tracing_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/background_tracing_manager_impl.h
diff --git a/content/browser/tracing/background_tracing_manager_impl.h b/content/browser/tracing/background_tracing_manager_impl.h
index 6ad99bbe59f743dd15e58d754da7ddb871c0acb8..8eeec970b8e3a84acaab62c532d72c12d81cd0b4 100644
--- a/content/browser/tracing/background_tracing_manager_impl.h
+++ b/content/browser/tracing/background_tracing_manager_impl.h
@@ -16,6 +16,7 @@
namespace content {
+class TraceMessageFilter;
class TracingDelegate;
class BackgroundTracingManagerImpl : public content::BackgroundTracingManager {
@@ -37,6 +38,8 @@ class BackgroundTracingManagerImpl : public content::BackgroundTracingManager {
void FireTimerForTesting() override;
bool HasActiveScenarioForTesting() override;
+ void OnHistogramTrigger(const std::string& histogram_name);
+
private:
BackgroundTracingManagerImpl();
~BackgroundTracingManagerImpl() override;
@@ -53,9 +56,13 @@ class BackgroundTracingManagerImpl : public content::BackgroundTracingManager {
void SetupUMACallbacks(SetupUMACallMode mode);
- void OnHistogramChanged(const std::string& histogram_name,
- base::Histogram::Sample reference_value,
- base::Histogram::Sample actual_value);
+ void OnHistogramChangedCallback(const std::string& histogram_name,
+ base::Histogram::Sample reference_value,
+ base::Histogram::Sample actual_value);
+ void OnTraceMessageFilterAdded(TraceMessageFilter* filter);
+ void SetupFiltersFromConfig(SetupUMACallMode mode);
+ void SetupFilterFromConfig(scoped_refptr<TraceMessageFilter> filter,
+ SetupUMACallMode mode);
scoped_ptr<base::DictionaryValue> GenerateMetadataDict() const;
« no previous file with comments | « components/tracing/tracing_messages.h ('k') | content/browser/tracing/background_tracing_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698