content/browser/tracing/background_tracing_manager_impl.h - Issue 1243743002: Slow Reports - Add message filter to trigger background traces from child processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/background_tracing_manager_impl.h

Issue 1243743002: Slow Reports - Add message filter to trigger background traces from child processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/tracing/tracing_messages.h ('k') | content/browser/tracing/background_tracing_manager_impl.cc » ('j') | content/browser/tracing/background_tracing_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/background_tracing_manager_impl.h

diff --git a/content/browser/tracing/background_tracing_manager_impl.h b/content/browser/tracing/background_tracing_manager_impl.h

index 6ad99bbe59f743dd15e58d754da7ddb871c0acb8..8eeec970b8e3a84acaab62c532d72c12d81cd0b4 100644

--- a/content/browser/tracing/background_tracing_manager_impl.h

+++ b/content/browser/tracing/background_tracing_manager_impl.h

@@ -16,6 +16,7 @@

namespace content {

+class TraceMessageFilter;

class TracingDelegate;

class BackgroundTracingManagerImpl : public content::BackgroundTracingManager {

@@ -37,6 +38,8 @@ class BackgroundTracingManagerImpl : public content::BackgroundTracingManager {

void FireTimerForTesting() override;

bool HasActiveScenarioForTesting() override;

+ void OnHistogramTrigger(const std::string& histogram_name);

private:

BackgroundTracingManagerImpl();

~BackgroundTracingManagerImpl() override;

@@ -53,9 +56,13 @@ class BackgroundTracingManagerImpl : public content::BackgroundTracingManager {

void SetupUMACallbacks(SetupUMACallMode mode);

- void OnHistogramChanged(const std::string& histogram_name,

- base::Histogram::Sample reference_value,

- base::Histogram::Sample actual_value);

+ void OnHistogramChangedCallback(const std::string& histogram_name,

+ base::Histogram::Sample reference_value,

+ base::Histogram::Sample actual_value);

+ void OnTraceMessageFilterAdded(TraceMessageFilter* filter);

+ void SetupFiltersFromConfig(SetupUMACallMode mode);

+ void SetupFilterFromConfig(scoped_refptr<TraceMessageFilter> filter,

+ SetupUMACallMode mode);

scoped_ptr<base::DictionaryValue> GenerateMetadataDict() const;