Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: components/tracing/child_trace_message_filter.cc

Issue 1243743002: Slow Reports - Add message filter to trigger background traces from child processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged into TraceMessageFilter. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/child_trace_message_filter.cc
diff --git a/components/tracing/child_trace_message_filter.cc b/components/tracing/child_trace_message_filter.cc
index 19fef02e106ca05b261a4ac5f264daeace5d6b62..3bb060b08e1c1e85b85c9f9f8adb43bf641a96fd 100644
--- a/components/tracing/child_trace_message_filter.cc
+++ b/components/tracing/child_trace_message_filter.cc
@@ -4,6 +4,7 @@
#include "components/tracing/child_trace_message_filter.h"
+#include "base/metrics/statistics_recorder.h"
#include "base/trace_event/trace_event.h"
#include "components/tracing/child_memory_dump_manager_delegate_impl.h"
#include "components/tracing/tracing_messages.h"
@@ -50,6 +51,8 @@ bool ChildTraceMessageFilter::OnMessageReceived(const IPC::Message& message) {
OnProcessMemoryDumpRequest)
IPC_MESSAGE_HANDLER(TracingMsg_GlobalMemoryDumpResponse,
OnGlobalMemoryDumpResponse)
+ IPC_MESSAGE_HANDLER(TracingMsg_SetUMACallback, OnSetUMACallback)
+ IPC_MESSAGE_HANDLER(TracingMsg_ClearUMACallback, OnClearUMACallback)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -226,4 +229,35 @@ void ChildTraceMessageFilter::OnGlobalMemoryDumpResponse(uint64 dump_guid,
pending_memory_dump_callback_.Run(dump_guid, success);
}
+void ChildTraceMessageFilter::OnHistogramChanged(
+ const std::string& histogram_name,
+ base::Histogram::Sample reference_value,
+ base::Histogram::Sample actual_value) {
+ if (actual_value < reference_value)
+ return;
+
+ ipc_task_runner_->PostTask(
+ FROM_HERE, base::Bind(&ChildTraceMessageFilter::SendTriggerMessage, this,
+ histogram_name));
+}
+
+void ChildTraceMessageFilter::SendTriggerMessage(
+ const std::string& histogram_name) {
+ if (sender_)
+ sender_->Send(new TracingHostMsg_TriggerBackgroundTrace(histogram_name));
+}
+
+void ChildTraceMessageFilter::OnSetUMACallback(
+ const std::string& histogram_name,
+ int histogram_value) {
+ base::StatisticsRecorder::SetCallback(
+ histogram_name, base::Bind(&ChildTraceMessageFilter::OnHistogramChanged,
+ this, histogram_name, histogram_value));
+}
+
+void ChildTraceMessageFilter::OnClearUMACallback(
+ const std::string& histogram_name) {
+ base::StatisticsRecorder::ClearCallback(histogram_name);
+}
+
} // namespace tracing

Powered by Google App Engine
This is Rietveld 408576698