Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12437010: Make SkOSWindow return the sample count and stencil bit count for its GL context. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make SkOSWindow return the sample count and stencil bit count for its GL context. Committed: https://code.google.com/p/skia/source/detail?r=7995

Patch Set 1 #

Patch Set 2 : Make SkOSWindow return the sample count and stencil bit count for its GL context. #

Patch Set 3 : Make SkOSWindow return the sample count and stencil bit count for its GL context. #

Patch Set 4 : Make SkOSWindow return the sample count and stencil bit count for its GL context. #

Patch Set 5 : Make SkOSWindow return the sample count and stencil bit count for its GL context. #

Total comments: 2

Patch Set 6 : Make SkOSWindow return the sample count and stencil bit count for its GL context. #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -50 lines) Patch
experimental/iOSSampleApp/Shared/SkUIView.h View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
experimental/iOSSampleApp/Shared/SkUIView.mm View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
experimental/iOSSampleApp/SkSampleUIView.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
experimental/iOSSampleApp/SkSampleUIView.mm View 1 2 3 4 5 6 4 chunks +18 lines, -6 lines 0 comments Download
include/views/SkOSWindow_Android.h View 1 2 3 4 5 6 1 chunk +9 lines, -1 line 0 comments Download
include/views/SkOSWindow_Mac.h View 1 2 3 4 5 6 1 chunk +6 lines, -1 line 0 comments Download
include/views/SkOSWindow_NaCl.h View 1 2 3 4 5 6 1 chunk +8 lines, -1 line 0 comments Download
include/views/SkOSWindow_Unix.h View 1 2 3 4 5 6 2 chunks +7 lines, -2 lines 0 comments Download
include/views/SkOSWindow_Win.h View 1 2 3 4 5 6 3 chunks +9 lines, -3 lines 0 comments Download
include/views/SkOSWindow_iOS.h View 1 2 3 4 5 6 1 chunk +6 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 6 2 chunks +6 lines, -5 lines 0 comments Download
M src/views/ios/SkOSWindow_iOS.mm View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M src/views/mac/SkNSView.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/views/mac/SkNSView.mm View 1 2 3 4 5 6 3 chunks +6 lines, -4 lines 0 comments Download
M src/views/mac/SkOSWindow_Mac.mm View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M src/views/unix/SkOSWindow_Unix.cpp View 1 2 3 4 5 6 5 chunks +22 lines, -4 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 1 2 3 4 5 6 10 chunks +37 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bsalomon
Make SkOSWindow return the sample count and stencil bit count for its GL context.
7 years, 9 months ago (2013-03-05 16:23:22 UTC) #1
bsalomon
Make SkOSWindow return the sample count and stencil bit count for its GL context.
7 years, 9 months ago (2013-03-05 18:38:13 UTC) #2
bsalomon
Make SkOSWindow return the sample count and stencil bit count for its GL context.
7 years, 9 months ago (2013-03-05 18:38:46 UTC) #3
bsalomon
Make SkOSWindow return the sample count and stencil bit count for its GL context.
7 years, 9 months ago (2013-03-05 18:49:24 UTC) #4
bsalomon
So that we don't query GL_STENCIL_BITS which is no longer valid in core profiles.
7 years, 9 months ago (2013-03-05 18:51:21 UTC) #5
robertphillips
lgtm + 1 question https://codereview.chromium.org/12437010/diff/12020/experimental/iOSSampleApp/Shared/SkUIView.mm File experimental/iOSSampleApp/Shared/SkUIView.mm (right): https://codereview.chromium.org/12437010/diff/12020/experimental/iOSSampleApp/Shared/SkUIView.mm#newcode97 experimental/iOSSampleApp/Shared/SkUIView.mm:97: info->fSampleCount = 0; 0 for ...
7 years, 9 months ago (2013-03-05 19:02:35 UTC) #6
bsalomon
https://codereview.chromium.org/12437010/diff/12020/experimental/iOSSampleApp/Shared/SkUIView.mm File experimental/iOSSampleApp/Shared/SkUIView.mm (right): https://codereview.chromium.org/12437010/diff/12020/experimental/iOSSampleApp/Shared/SkUIView.mm#newcode97 experimental/iOSSampleApp/Shared/SkUIView.mm:97: info->fSampleCount = 0; On 2013/03/05 19:02:35, robertphillips wrote: > ...
7 years, 9 months ago (2013-03-05 19:13:03 UTC) #7
bsalomon
Make SkOSWindow return the sample count and stencil bit count for its GL context.
7 years, 9 months ago (2013-03-05 19:17:15 UTC) #8
bsalomon
7 years, 9 months ago (2013-03-05 20:06:10 UTC) #9
Message was sent while issue was closed. 
Committed patchset #7 manually as r7995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698