Android MediaSession: do not resume a UI suspended session on a system resume.

Android MediaSession: do not resume a UI suspended session on a system resume.

When a session is suspended by the UI from the media notifications, it
does not release the audio focus and might receive focus loss/gain
messages from the system. It shouldn't try to resume the session when
the focus is gained back in such case.

BUG=511921
Committed: https://crrev.com/66c6978bdb49a99c387c11f94b35df1f8902d49c
Cr-Commit-Position: refs/heads/master@{#339801}

[mlamouri (slow - plz ping), 2015-07-20 19:30:55]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org, qinmin@chromium.org

[mlamouri (slow - plz ping), 2015-07-20 19:30:56]

I need to add tests and I will do that tomorrow but if you guys could have a
look before, it would be great.

[mlamouri (slow - plz ping), 2015-07-21 19:14:35]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 19:15:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1243683003/20001

[mlamouri (slow - plz ping), 2015-07-21 19:15:38]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org

[mlamouri (slow - plz ping), 2015-07-21 19:15:38]

qinmin@ and avayvoyd@, could you review changes in:
 content/browser/media/android/

jochen@, can you review changes in:
 content/browser/web_contents/web_contents_impl.cc


Thanks! :)

[whywhat, 2015-07-21 19:21:28]

lgtm with a couple of nits

https://codereview.chromium.org/1243683003/diff/20001/content/browser/media/a...
File content/browser/media/android/media_session_browsertest.cc (right):

https://codereview.chromium.org/1243683003/diff/20001/content/browser/media/a...
content/browser/media/android/media_session_browsertest.cc:803:
EXPECT_FALSE(IsSuspended());
Add a test that checks that Suspend(System) and Resume(System) works as
intended.

https://codereview.chromium.org/1243683003/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1243683003/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3319:
MediaSession::Get(this)->Resume(MediaSession::SuspendType::UI);
Perhaps you could pass the SuspendType::UI from Resume() and Suspend() and
SuspendType::System from OnResume/OnSuspend to avoid changing the MediaSession's
public API.

[commit-bot: I haz the power, 2015-07-21 20:30:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 20:30:38]

Dry run: This issue passed the CQ dry run.

[qinmin, 2015-07-21 22:58:17]

lgtm % comments

https://codereview.chromium.org/1243683003/diff/20001/content/browser/media/a...
File content/browser/media/android/media_session.h (left):

https://codereview.chromium.org/1243683003/diff/20001/content/browser/media/a...
content/browser/media/android/media_session.h:100: Active,
change all the enum names here
ACTIVE, SUSPENDED, INACTIVE

https://codereview.chromium.org/1243683003/diff/20001/content/browser/media/a...
File content/browser/media/android/media_session.h (right):

https://codereview.chromium.org/1243683003/diff/20001/content/browser/media/a...
content/browser/media/android/media_session.h:43: System,
s/System/SYSTEM/

[mlamouri (slow - plz ping), 2015-07-21 23:58:54]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-07-21 23:58:55]

All comments applied.

[mlamouri (slow - plz ping), 2015-07-21 23:58:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
avayvod@chromium.org, qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/1243683003/#ps40001
(title: "review comments")

[mlamouri (slow - plz ping), 2015-07-21 23:59:08]

mlamouri@chromium.org changed reviewers:
- jochen@chromium.org

[commit-bot: I haz the power, 2015-07-21 23:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1243683003/40001

[commit-bot: I haz the power, 2015-07-22 00:49:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-22 00:51:34]

Patchset 3 (id:??) landed as
https://crrev.com/66c6978bdb49a99c387c11f94b35df1f8902d49c
Cr-Commit-Position: refs/heads/master@{#339801}