Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1243633002: Don't pass "-b" to gsutil when downloading go tool binaries. (Closed)

Created:
5 years, 5 months ago by ppi
Modified:
5 years, 5 months ago
Reviewers:
rogulenko, viettrungluu
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't pass "-b" to gsutil when downloading go tool binaries. Recently updated gsutil in depot_tools doesn't offer the "-b" (bypass_prodaccess) flag anymore, causing the download to fail: ________ running '/usr/bin/python src/tools/go/download.py' in '/home/ppi/projects/mojo' CommandException: option -b not recognized Running ['python', '/home/ppi/Install/depot_tools/gsutil.py', '-b', 'cp', 'gs://mojo/go/tool/390daacbfac646491c8ac7469195105ac0ce2c46.tar.gz', '/home/ppi/projects/mojo/src/third_party/go/tool/go.tar.gz'] Failed. WARNING: Failed to download Go tool binaries. Skipping "-b" makes the download work a public network, presumably it is not needed anymore? R=rogulenko@google.com Committed: https://chromium.googlesource.com/external/mojo/+/97b3360decaf5d0fa129f67e6648e7b81516d6fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/go/download.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Trung or Sergey, ptal.
5 years, 5 months ago (2015-07-19 16:06:18 UTC) #2
rogulenko
lgtm
5 years, 5 months ago (2015-07-20 09:20:52 UTC) #3
ppi
5 years, 5 months ago (2015-07-20 13:23:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97b3360decaf5d0fa129f67e6648e7b81516d6fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698