ui/views/controls/textfield/native_textfield_views.cc - Issue 12436011: Fix CrOS Beta (branch 1410) Omnibox select-all on click-to-focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/native_textfield_views.cc

Issue 12436011: Fix CrOS Beta (branch 1410) Omnibox select-all on click-to-focus. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1410/src/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/textfield/native_textfield_views.cc

===================================================================

--- ui/views/controls/textfield/native_textfield_views.cc (revision 187382)

+++ ui/views/controls/textfield/native_textfield_views.cc (working copy)

@@ -96,9 +96,7 @@

TrackMouseClicks(event);

TextfieldController* controller = textfield_->GetController();

- if (!(controller && controller->HandleMouseEvent(textfield_, event)) ||

- // TODO: Remove once NativeTextfield implementations are consolidated to

- // Textfield.

+ if (!(controller && controller->HandleMouseEvent(textfield_, event)) &&

!textfield_->OnMousePressed(event)) {

HandleMousePressEvent(event);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »