Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 12436011: Fix CrOS Beta (branch 1410) Omnibox select-all on click-to-focus. (Closed)

Created:
7 years, 9 months ago by msw
Modified:
7 years, 9 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, tanyarad_chromium.org, benry
Visibility:
Public.

Description

Fix CrOS Beta (branch 1410) Omnibox select-all on click-to-focus. The CrOS Beta (branch 1410) omnibox doesn't select-all on click-to-focus. This is the minimal fix from http://crrev.com/183239, which doesn't apply. ( unrelated parts depend on http://crrev.com/183146 and http://crrev.com/183198 ) Run applicable handlers in NativeTextfieldViews::OnMousePressed. (textfield_->OnMousePressed wasn't being run properly due to logic error) NOTE: Landing this CL will expose another issue on branch 1410: http://crbug.com/165873 - "first" double click doesn't work correct... That will be fixed by merging http://crrev.com/187643 to branch 1410. BUG=181406, 165873, 176708 TEST=CrOS Beta Omnibox selects-all on click-to-focus. R=pkasting@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Peter and Scott, please take a look; thanks! Release owners CC'ed.
7 years, 9 months ago (2013-03-12 07:38:55 UTC) #1
sky
LGTM
7 years, 9 months ago (2013-03-12 14:22:50 UTC) #2
Peter Kasting
I wondered about that "or" in the original change and eventually decided you knew what ...
7 years, 9 months ago (2013-03-13 00:20:37 UTC) #3
msw
On 2013/03/13 00:20:37, Peter Kasting wrote: > I wondered about that "or" in the original ...
7 years, 9 months ago (2013-03-13 00:29:45 UTC) #4
Evan Stade
sorry for breakage.
7 years, 9 months ago (2013-03-13 01:23:46 UTC) #5
msw
7 years, 9 months ago (2013-03-14 19:22:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r188155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698