Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Issue 1243553002: Revert of Debugger: use FrameInspector in ScopeIterator to find context. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Debugger: use FrameInspector in ScopeIterator to find context. (patchset #3 id:40001 of https://codereview.chromium.org/1239033002/) Reason for revert: breaks roll: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/87292/steps/browser_tests%20%28with%20patch%29/logs/DevToolsSanityTest.TestPauseWhenScriptIsRunning Original issue's description: > Debugger: use FrameInspector in ScopeIterator to find context. > > In optimized code, it's not guaranteed that the current context > is stored in its frame slot. > > R=bmeurer@chromium.org > BUG=v8:4309 > LOG=N > > Committed: https://crrev.com/3a0ee39cbde6a9778cfc4e2a6a0a8ff68933ff38 > Cr-Commit-Position: refs/heads/master@{#29697} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4309 Committed: https://crrev.com/c062b28aebdf881674b074f0727dfbf00b936db8 Cr-Commit-Position: refs/heads/master@{#29722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -182 lines) Patch
M src/debug.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 25 chunks +58 lines, -58 lines 0 comments Download
M test/mjsunit/es6/debug-blockscopes.js View 4 chunks +6 lines, -14 lines 0 comments Download
D test/mjsunit/regress/regress-4309-1.js View 1 chunk +0 lines, -37 lines 0 comments Download
D test/mjsunit/regress/regress-4309-2.js View 1 chunk +0 lines, -34 lines 0 comments Download
D test/mjsunit/regress/regress-4309-3.js View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
Created Revert of Debugger: use FrameInspector in ScopeIterator to find context.
5 years, 5 months ago (2015-07-17 09:53:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243553002/1
5 years, 5 months ago (2015-07-17 09:53:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 09:53:46 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c062b28aebdf881674b074f0727dfbf00b936db8 Cr-Commit-Position: refs/heads/master@{#29722}
5 years, 5 months ago (2015-07-17 09:54:01 UTC) #4
Michael Achenbach
5 years, 5 months ago (2015-07-17 09:55:45 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698