Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: content/common/gpu/media/dxva_video_decode_accelerator.cc

Issue 1243543002: Fix incorrect usage of the RETURN_ON_FAILURE and RETURN_ON_HR_FAILURE macros in the CreateCOMObject… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/dxva_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/dxva_video_decode_accelerator.cc b/content/common/gpu/media/dxva_video_decode_accelerator.cc
index 84b00ee3c2f4adb10fa56a58f50b02c701006644..0609b51a814bb3c9108fd63baf9b4b1b9b6b6b4c 100644
--- a/content/common/gpu/media/dxva_video_decode_accelerator.cc
+++ b/content/common/gpu/media/dxva_video_decode_accelerator.cc
@@ -258,14 +258,14 @@ HRESULT CreateCOMObjectFromDll(HMODULE dll, const CLSID& clsid, const IID& iid,
GetClassObject get_class_object = reinterpret_cast<GetClassObject>(
GetProcAddress(dll, "DllGetClassObject"));
RETURN_ON_FAILURE(
- get_class_object, "Failed to get DllGetClassObject pointer", false);
+ get_class_object, "Failed to get DllGetClassObject pointer", E_FAIL);
base::win::ScopedComPtr<IClassFactory> factory;
HRESULT hr = get_class_object(
clsid,
__uuidof(IClassFactory),
factory.ReceiveVoid());
- RETURN_ON_HR_FAILURE(hr, "DllGetClassObject failed", false);
+ RETURN_ON_HR_FAILURE(hr, "DllGetClassObject failed", hr);
hr = factory->CreateInstance(NULL, iid, object);
return hr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698