Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1243533005: Revert of Fix content verifier problem with content scripts (Closed)

Created:
5 years, 5 months ago by kelvinp
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix content verifier problem with content scripts (patchset #3 id:40001 of https://codereview.chromium.org/1226163010/) Reason for revert: The ContentVerifierTest.ContentScripts test introduced in this change has been failing consistently on Vista. See below http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/57878 http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/57877 Original issue's description: > Fix content verifier problem with content scripts > > The problem is that we were creating the ContentVerifier too late > in ExtensionSystemImpl::Shared::Init, after the script loader had > already tried grabbing a reference to it for use on another > thead. Therefore at run time, for all content scripts we were was > seeing a null pointer for the content verifier and skipping > verification of those scripts. > > BUG=509130 > > Committed: https://crrev.com/fe6dc62c549db502a0323ebbebab7ffd4f5cebd7 > Cr-Commit-Position: refs/heads/master@{#339283} TBR=rockot@chromium.org,asargent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=509130 Committed: https://crrev.com/b9e8b50e4c45d8aefacac58e28c50d83bb257b7b Cr-Commit-Position: refs/heads/master@{#339361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -174 lines) Patch
M chrome/browser/extensions/content_verifier_browsertest.cc View 7 chunks +23 lines, -136 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/content_verifier/content_script.crx View Binary file 0 comments Download
M extensions/browser/content_verifier.h View 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/browser/content_verifier.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kelvinp
Created Revert of Fix content verifier problem with content scripts
5 years, 5 months ago (2015-07-18 00:07:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243533005/1
5 years, 5 months ago (2015-07-18 00:08:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-18 00:09:45 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-18 00:11:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9e8b50e4c45d8aefacac58e28c50d83bb257b7b
Cr-Commit-Position: refs/heads/master@{#339361}

Powered by Google App Engine
This is Rietveld 408576698