linux_aura: Call MapThemeImage for resources missing in native theme

linux_aura: Call MapThemeImage for resources missing in native theme

For resources not provided by the native theme (i.e. GTK2UI), fall
back to desktop (not ash) resources by calling MapThemeImage in this
case.

BUG=383711
R=erg@chromium.org
TEST=The shadow running along the top edge of the address bar to the
right of the tabs is visible again, especially when using a bright GTK
theme like Adwaita or Radiance. (see crbug.com/383711)

Committed: https://crrev.com/bbc3cefbf4555599d3be3684140a835ef639ce7d
Cr-Commit-Position: refs/heads/master@{#339744}

[jclw, 2015-07-17 00:19:59]

see also http://crbug.com/383711#c9

[Elliot Glaysher, 2015-07-17 17:06:28]

Thank you for looking at this.

https://codereview.chromium.org/1243513002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc
(right):

https://codereview.chromium.org/1243513002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc:36:
chrome::MapThemeImage(chrome::HOST_DESKTOP_TYPE_NATIVE, id));
nit: this return line looks duplicated. Prefer something like this instead:

if (delegate_->UsingSystemTheme() && delegate_->HasCustomImage(id))
    return delegate_->GetImageSkiaNamed(id);
return /* mapped case */;

[jclw, 2015-07-21 20:11:38]

This is now a one-liner.  Please excuse the delay.

https://codereview.chromium.org/1243513002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc
(right):

https://codereview.chromium.org/1243513002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc:36:
chrome::MapThemeImage(chrome::HOST_DESKTOP_TYPE_NATIVE, id));
On 2015/07/17 17:06:28, Elliot Glaysher wrote:
> nit: this return line looks duplicated. Prefer something like this instead:
> 
> if (delegate_->UsingSystemTheme() && delegate_->HasCustomImage(id))
>     return delegate_->GetImageSkiaNamed(id);
> return /* mapped case */;

Done.

[Elliot Glaysher, 2015-07-21 20:13:20]

Thank you for your contribution. LGTM.

[Elliot Glaysher, 2015-07-21 20:13:23]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2015-07-21 20:14:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1243513002/20001

[commit-bot: I haz the power, 2015-07-21 20:52:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-21 20:53:15]

Patchset 2 (id:??) landed as
https://crrev.com/bbc3cefbf4555599d3be3684140a835ef639ce7d
Cr-Commit-Position: refs/heads/master@{#339744}