make glyph_pos imageblur* largeglyphblur portable

make glyph_pos imageblur* largeglyphblur portable

R=reed@google.com,bungeman@google.com

Committed: https://skia.googlesource.com/skia/+/ef14cb397cca75607019e2cc401d4bb9969ed105

[caryclark, 2015-07-16 21:08:18]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2015-07-16 21:08:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1243493003/20001

[commit-bot: I haz the power, 2015-07-16 21:08:38]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-07-17 03:08 UTC

[reed1, 2015-07-16 21:14:04]

lgtm w/ question about 565 "safe" colors + antialiasing

https://codereview.chromium.org/1243493003/diff/20001/gm/imageblur.cpp
File gm/imageblur.cpp (right):

https://codereview.chromium.org/1243493003/diff/20001/gm/imageblur.cpp#newcode48
gm/imageblur.cpp:48:
textPaint.setColor(sk_tool_utils::color_to_565(rand.nextBits(24) | 0xFF000000));
Does this actually result in zero-diffs, given that the paint has antialiasing
on?

[commit-bot: I haz the power, 2015-07-16 21:16:08]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ef14cb397cca75607019e2cc401d4bb9969ed105

[caryclark, 2015-07-17 12:42:31]

https://codereview.chromium.org/1243493003/diff/20001/gm/imageblur.cpp
File gm/imageblur.cpp (right):

https://codereview.chromium.org/1243493003/diff/20001/gm/imageblur.cpp#newcode48
gm/imageblur.cpp:48:
textPaint.setColor(sk_tool_utils::color_to_565(rand.nextBits(24) | 0xFF000000));
On 2015/07/16 21:14:04, reed1 wrote:
> Does this actually result in zero-diffs, given that the paint has antialiasing
> on?

No, but it reduces the number of diffs. I've largely given up on zero diffs;
instead, I try to minimize the diffs so any actual bugs stand out.