Issue 124343003: Only aura_bench needs cc/ dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124343003: Only aura_bench needs cc/ dependency. (Closed)

Created:
6 years, 11 months ago by tfarina

Modified:
6 years, 11 months ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank, tony

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Only aura_bench needs cc/ dependency. The rest of aura targets do not reference cc/, so they don't need to explicit list cc/ as a dependency. BUG=None TEST=aura_bench, aura_demo, aura_unittests, all three still links R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243719

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/aura/aura.gyp	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

tfarina

6 years, 11 months ago (2014-01-09 01:04:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r243719 (presubmit successful).