Skip the Service Worker CORS fallback for same origin requests. [1/2 blink]

Source/core/loader/DocumentThreadableLoader.cpp

Index: Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/Source/core/loader/DocumentThreadableLoader.cpp b/Source/core/loader/DocumentThreadableLoader.cpp
index 8b84b7147cada891d7ace3393be6bb007a543489..7057620cd88f5bafe4bb185c11db6eeeb774b0ea 100644
--- a/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/Source/core/loader/DocumentThreadableLoader.cpp
@@ -452,7 +452,13 @@ void DocumentThreadableLoader::handleResponse(unsigned long identifier, const Re
         return;
     }
 
-    ASSERT(!m_fallbackRequestForServiceWorker);
+    // |m_fallbackRequestForServiceWorker| may be set only wheh the request is

[tyoshino (SeeGerritForStatus), 2015/07/22 11:25:45]

wheh -> when

+    // same origin, because we skip the Service Worker CORS fallback for same
+    // origin requests.

[tyoshino (SeeGerritForStatus), 2015/07/22 11:25:45]

|m_fallbackRequestForServiceWorker| being set is not a result of loading. So,
this text looks a little strange.

It's hard to phrase... How about:

Even if the request met the conditions to get handled by a Service Worker in the
constructor of this class (and therefore |m_fallbackRequestForServiceWorker| is
set), the Service Worker may skip processing the request. Only if the request is
same origin, the skipped response may come here (wasFetchedViaServiceWorker()
returns false) since such a request doesn't have to go through the CORS
algorithm by calling loadFallbackRequestForServiceWorker().

[horo, 2015/07/22 14:28:08]

Done.

+    // FIXME: We should use |m_sameOriginRequest| when we will support
+    // Suborigins for Service Worker.
+    ASSERT(!m_fallbackRequestForServiceWorker || securityOrigin()->canRequest(m_fallbackRequestForServiceWorker->url()));
+    m_fallbackRequestForServiceWorker = nullptr;
 
     if (!m_sameOriginRequest && m_options.crossOriginRequestPolicy == UseAccessControl) {
         String accessControlErrorDescription;