Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: memory/globalinfo.go

Issue 1243323002: Refactor a bit. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: fix golint Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « memory/gkvlite_utils_test.go ('k') | memory/memcache.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: memory/globalinfo.go
diff --git a/memory/globalinfo.go b/memory/globalinfo.go
deleted file mode 100644
index 39b1e126b877284685b78b702f8269062829c8d0..0000000000000000000000000000000000000000
--- a/memory/globalinfo.go
+++ /dev/null
@@ -1,54 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package memory
-
-import (
- "golang.org/x/net/context"
-
- "github.com/luci/gae"
- "github.com/luci/gae/dummy"
-)
-
-type giContextKeyType int
-
-var giContextKey giContextKeyType
-
-func curGID(c context.Context) *globalInfoData {
- return c.Value(giContextKey).(*globalInfoData)
-}
-
-// useGI adds a gae.GlobalInfo context, accessible
-// by gae.GetGI(c)
-func useGI(c context.Context) context.Context {
- return gae.SetGIFactory(c, func(ic context.Context) gae.GlobalInfo {
- return &giImpl{dummy.GI(), curGID(ic), ic}
- })
-}
-
-// globalAppID is the 'AppID' of everythin returned from this memory
-// implementation (DSKeys, GlobalInfo, etc.). There's no way to modify this
-// value through the API, and there are a couple bits of code where it's hard to
-// route this value through to without making the internal APIs really complex.
-const globalAppID = "dev~app"
-
-type globalInfoData struct {
- namespace string
-}
-
-type giImpl struct {
- gae.GlobalInfo
- *globalInfoData
- c context.Context
-}
-
-var _ = gae.GlobalInfo((*giImpl)(nil))
-
-func (gi *giImpl) Namespace(ns string) (ret context.Context, err error) {
- return context.WithValue(gi.c, giContextKey, &globalInfoData{ns}), nil
-}
-
-func (gi *giImpl) AppID() string {
- return globalAppID
-}
« no previous file with comments | « memory/gkvlite_utils_test.go ('k') | memory/memcache.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698