Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: helper/datastore.go

Issue 1243323002: Refactor a bit. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: fix golint Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « globalinfo.go ('k') | helper/datastore_impl.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: helper/datastore.go
diff --git a/helper/datastore.go b/helper/datastore.go
deleted file mode 100644
index 038dbbbe92f41cfa293b86fdc5f77910f033ccf8..0000000000000000000000000000000000000000
--- a/helper/datastore.go
+++ /dev/null
@@ -1,35 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// HEAVILY adapted from github.com/golang/appengine/datastore
-
-package helper
-
-import (
- "reflect"
-
- "github.com/luci/gae"
-)
-
-// GetPLS resolves o into a gae.DSStructPLS. o must be a pointer to a
-// struct of some sort.
-func GetPLS(o interface{}) gae.DSPropertyLoadSaver {
- v := reflect.ValueOf(o)
- if v.Kind() != reflect.Ptr || v.Elem().Kind() != reflect.Struct {
- return &structPLS{c: &structCodec{problem: gae.ErrDSInvalidEntityType}}
- }
- v = v.Elem()
- t := v.Type()
-
- structCodecsMutex.RLock()
- if c, ok := structCodecs[t]; ok {
- structCodecsMutex.RUnlock()
- return &structPLS{v, c}
- }
- structCodecsMutex.RUnlock()
-
- structCodecsMutex.Lock()
- defer structCodecsMutex.Unlock()
- return &structPLS{v, getStructCodecLocked(t)}
-}
« no previous file with comments | « globalinfo.go ('k') | helper/datastore_impl.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698