Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 12433023: Move chrome/browser/chromeos/process_proxy to chromeos (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
Reviewers:
satorux1, tbarzic, sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move chrome/browser/chromeos/process_proxy to chromeos BUG=180711 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187641

Patch Set 1 #

Patch Set 2 : CHROMEOS_EXPORT #

Patch Set 3 : more CHROMEOS_EXPORT #

Patch Set 4 : fixes #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -1241 lines) Patch
D chrome/browser/chromeos/process_proxy/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/process_proxy/process_output_watcher.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/chromeos/process_proxy/process_output_watcher.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/chromeos/process_proxy/process_output_watcher_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/chromeos/process_proxy/process_proxy.h View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/chromeos/process_proxy/process_proxy.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D chrome/browser/chromeos/process_proxy/process_proxy_browsertest.cc View 1 chunk +0 lines, -253 lines 0 comments Download
D chrome/browser/chromeos/process_proxy/process_proxy_registry.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/chromeos/process_proxy/process_proxy_registry.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M chrome/browser/extensions/api/terminal/terminal_private_api.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
A + chromeos/process_proxy/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/process_proxy/process_output_watcher.h View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
A + chromeos/process_proxy/process_output_watcher.cc View 3 chunks +5 lines, -1 line 0 comments Download
A + chromeos/process_proxy/process_output_watcher_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + chromeos/process_proxy/process_proxy.h View 5 chunks +11 lines, -4 lines 0 comments Download
A + chromeos/process_proxy/process_proxy.cc View 8 chunks +21 lines, -10 lines 0 comments Download
A + chromeos/process_proxy/process_proxy_registry.h View 1 4 chunks +12 lines, -12 lines 0 comments Download
A + chromeos/process_proxy/process_proxy_registry.cc View 1 2 3 8 chunks +21 lines, -2 lines 0 comments Download
A + chromeos/process_proxy/process_proxy_unittest.cc View 10 chunks +32 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-07 00:22:24 UTC) #1
tbarzic
On 2013/03/07 00:22:24, Paweł Hajdan Jr. wrote: lgtm
7 years, 9 months ago (2013-03-07 18:09:32 UTC) #2
Paweł Hajdan Jr.
Toni, could you take another look, especially at process_proxy_registry.cc ? I added DCHECKs for CalledOnValidThread(), ...
7 years, 9 months ago (2013-03-08 18:39:26 UTC) #3
tonibarzic
On 2013/03/08 18:39:26, Paweł Hajdan Jr. wrote: > Toni, could you take another look, especially ...
7 years, 9 months ago (2013-03-08 18:49:12 UTC) #4
sky
LGTM
7 years, 9 months ago (2013-03-08 21:45:53 UTC) #5
satorux1
LGTM
7 years, 9 months ago (2013-03-11 01:20:12 UTC) #6
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-12 20:22:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r187641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698