Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: utils/pub/version_solver.dart

Issue 12433014: Dev dependencies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: List all colliding package names. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/sdk_source.dart ('k') | utils/tests/pub/dev_dependency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/version_solver.dart
diff --git a/utils/pub/version_solver.dart b/utils/pub/version_solver.dart
index 45d47e8aa75a4c1eb87381501461c64254a56ef0..c00cda5f533ff5a1e3766a335eb47abb0c7cf588 100644
--- a/utils/pub/version_solver.dart
+++ b/utils/pub/version_solver.dart
@@ -283,8 +283,8 @@ class ChangeVersion implements WorkItem {
Version version) {
// If there is no version, it means no package, so no dependencies.
if (version == null) {
- return
- new Future<Map<String, PackageRef>>.immediate(<String, PackageRef>{});
+ return new Future<Map<String, PackageRef>>.immediate(
+ <String, PackageRef>{});
}
var id = new PackageId(package, source, version, description);
@@ -293,6 +293,14 @@ class ChangeVersion implements WorkItem {
for (var dependency in pubspec.dependencies) {
dependencies[dependency.name] = dependency;
}
+
+ // Include dev dependencies only from the root package.
+ if (id.isRoot) {
+ for (var dependency in pubspec.devDependencies) {
+ dependencies[dependency.name] = dependency;
+ }
+ }
+
return dependencies;
});
}
« no previous file with comments | « utils/pub/sdk_source.dart ('k') | utils/tests/pub/dev_dependency_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698