Platform-specific prune state storage.

chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/incident_reporting/state_store.h"
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/values.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/browser/prefs/pref_service_syncable_factory.h"
 #include "chrome/browser/safe_browsing/incident_reporting/incident.h"
+#include "chrome/browser/safe_browsing/incident_reporting/platform_state_store.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if defined(OS_WIN)
+#include "base/test/test_reg_util_win.h"
+#endif
+
 namespace safe_browsing {
 
+#if defined(OS_WIN)
+
+// A base test fixture that redirects HKCU for testing the platform state store
+// backed by the Windows registry to prevent interference with existing Chrome
+// installs or other tests.
+class PlatformStateStoreTestBase : public ::testing::Test {
+ protected:
+  PlatformStateStoreTestBase() {}
+
+  void SetUp() override {
+    ::testing::Test::SetUp();
+    registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER);

[robertshield, 2015/09/01 14:20:12]

given that this and the declaration of registry_override_manager_ are the only
things the base class does, you could shorten this by inlining it in
StateStoreTest and doing away with the conditionally-defined base class.

[grt (UTC plus 2), 2015/09/03 18:12:05]

I decided to go this route since other platforms will surely need their own
magic. I like how this isolates the platform-specific changes.

+  }
+
+ private:
+  registry_util::RegistryOverrideManager registry_override_manager_;
+
+  DISALLOW_COPY_AND_ASSIGN(PlatformStateStoreTestBase);
+};
+
+#else  // OS_WIN
+
+using PlatformStateStoreTestBase = ::testing::Test;
+
+#endif  // !OS_WIN
+
 // A test fixture with a testing profile that writes its user prefs to a json
 // file.
-class StateStoreTest : public ::testing::Test {
+class StateStoreTest : public PlatformStateStoreTestBase {
  protected:
   struct TestData {
     IncidentType type;
     const char* key;
     uint32_t digest;
   };
 
   StateStoreTest()
       : profile_(nullptr),
         task_runner_(new base::TestSimpleTaskRunner()),
         thread_task_runner_handle_(task_runner_),
         profile_manager_(TestingBrowserProcess::GetGlobal()) {}
 
   void SetUp() override {
-    testing::Test::SetUp();
+    PlatformStateStoreTestBase::SetUp();
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
     ASSERT_TRUE(profile_manager_.SetUp());
     CreateProfile();
   }
 
   void DeleteProfile() {
     if (profile_) {
       profile_ = nullptr;
       profile_manager_.DeleteTestingProfile(kProfileName_);
     }
@@ skipping 136 matching lines @@
 
   // Delete the profile.
   DeleteProfile();
 
   // Delete the state pref.
   TrimPref();
 
   // Recreate the profile.
   CreateProfile();
 
-  // Verify that the state did not survive.
   StateStore state_store(profile_);
-  for (const auto& data : kTestData_)
+  for (const auto& data : kTestData_) {
+#if defined(USE_PLATFORM_STATE_STORE)
+    // Verify that the state survived.
+    ASSERT_TRUE(state_store.HasBeenReported(data.type, data.key, data.digest));
+#else
+    // Verify that the state did not survive.
     ASSERT_FALSE(state_store.HasBeenReported(data.type, data.key, data.digest));
+#endif
+  }
 }
 
 }  // namespace safe_browsing