Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1243273003: Fix Closure Compiler error which is introduced by crrev.com/1233913010 (Closed)

Created:
5 years, 5 months ago by yawano
Modified:
5 years, 5 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Closure Compiler error which is introduced by crrev.com/1233913010 BUG=509483 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/319562c8d45271b5e360abd6a27f0caaa6eb23bc Cr-Commit-Position: refs/heads/master@{#339847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -62 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 2 chunks +74 lines, -62 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 5 months ago (2015-07-22 05:14:23 UTC) #2
mtomasz
lgtm!
5 years, 5 months ago (2015-07-22 07:51:55 UTC) #3
yawano
On 2015/07/22 07:51:55, mtomasz wrote: > lgtm! Thank you!
5 years, 5 months ago (2015-07-22 07:52:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243273003/1
5 years, 5 months ago (2015-07-22 07:52:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 08:36:29 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 08:37:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/319562c8d45271b5e360abd6a27f0caaa6eb23bc
Cr-Commit-Position: refs/heads/master@{#339847}

Powered by Google App Engine
This is Rietveld 408576698