Issue 1243253005: [turbofan] Remove deprecated code from RawMachineAssembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1243253005: [turbofan] Remove deprecated code from RawMachineAssembler. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger

Modified:
5 years, 5 months ago

Reviewers:
rmcilroy

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Remove deprecated code from RawMachineAssembler. This mostly removes dead code and obsolete special cases from the RawMachineAssembler::MakeNode helper, that shouldn't be necessary anymore. R=rmcilroy@chromium.org Committed: https://crrev.com/c00f7dffc1b60cb1f0afd481fdfbd2a86d07ba99 Cr-Commit-Position: refs/heads/master@{#29817}

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -20 lines)			Patch
	M	src/compiler/raw-machine-assembler.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	src/compiler/raw-machine-assembler.cc	View		8 chunks	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmcilroy

On 2015/07/23 12:26:45, Michael Starzinger wrote: lgtm, thanks.

5 years, 5 months ago (2015-07-23 12:41:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243253005/1

5 years, 5 months ago (2015-07-23 14:36:20 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-23 14:39:04 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c00f7dffc1b60cb1f0afd481fdfbd2a86d07ba99
Cr-Commit-Position: refs/heads/master@{#29817}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages