chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 1243253004: Pass user gesture bit when chrome handles an intent fired by itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 1243253004: Pass user gesture bit when chrome handles an intent fired by itself (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix findbugs warning Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 1b9a0bdd73ce1b8b3a95e37b1bb7f2023a97f650..1f146d9291acaab139d7f09eaf2a346b2e339b99 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -619,7 +619,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements ActionBarDel

@Override

public void processUrlViewIntent(String url, String referer, String headers,

TabOpenType tabOpenType, String externalAppId, int tabIdToBringToFront,

- Intent intent) {

+ boolean hasUserGesture, Intent intent) {

TabModel tabModel = getCurrentTabModel();

switch (tabOpenType) {

case REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB:

@@ -673,6 +673,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements ActionBarDel

int transitionType = PageTransition.LINK | PageTransition.FROM_API;

LoadUrlParams loadUrlParams = new LoadUrlParams(url, transitionType);

loadUrlParams.setIntentReceivedTimestamp(mIntentHandlingTimeMs);

+ loadUrlParams.setHasUserGesture(hasUserGesture);

currentTab.loadUrl(loadUrlParams);

RecordUserAction.record("MobileTabClobbered");

} else {