Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1243213004: Remove d8's interactive Javascript debugger. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove d8's interactive Javascript debugger. The code is unmaintained and full of errors... but this CL wipes them all away. Nobody seems to use it anyways. R=mvstanton@chromium.org Committed: https://crrev.com/cd0015aad0d4d5d3ecc4d3dae281a3f941111d85 Cr-Commit-Position: refs/heads/master@{#29801}

Patch Set 1 #

Patch Set 2 : fix shared library build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2202 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/d8.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/d8.cc View 1 13 chunks +5 lines, -104 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/d8.js View 3 chunks +1 line, -1913 lines 0 comments Download
D src/d8-debug.h View 1 chunk +0 lines, -20 lines 0 comments Download
D src/d8-debug.cc View 1 chunk +0 lines, -153 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years, 5 months ago (2015-07-23 08:26:49 UTC) #1
mvstanton
lgtm
5 years, 5 months ago (2015-07-23 08:27:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213004/1
5 years, 5 months ago (2015-07-23 08:27:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/3138)
5 years, 5 months ago (2015-07-23 08:37:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213004/20001
5 years, 5 months ago (2015-07-23 08:58:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 09:49:25 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 09:49:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd0015aad0d4d5d3ecc4d3dae281a3f941111d85
Cr-Commit-Position: refs/heads/master@{#29801}

Powered by Google App Engine
This is Rietveld 408576698