Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1243213002:
Credential passing is the only way for passwords now. (Closed)
DescriptionCredential passing is the only way for passwords now.
embedded_setup_chromeos now uses SAML api to set the password.
BUG=467778
Committed: https://crrev.com/317ba3276ca7bda6433f7f953b17e92640fb258b
Cr-Commit-Position: refs/heads/master@{#348631}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : fix browsertests #
Messages
Total messages: 44 (19 generated)
achuith@chromium.org changed reviewers: + dzhioev@chromium.org
Pavel, please take a look
On 2015/07/21 19:21:56, achuithb wrote: > Pavel, please take a look LGTM
On 2015/07/21 20:55:28, dzhioev wrote: > On 2015/07/21 19:21:56, achuithb wrote: > > Pavel, please take a look > > LGTM ty
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by achuith@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@chromium.org Link to the patchset: https://codereview.chromium.org/1243213002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Pavel, please take another look
On 2015/08/07 07:08:08, achuithb wrote: > Pavel, please take another look LGTM
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
achuith@chromium.org changed reviewers: + rogerta@chromium.org
Roger, need owner lgtm for embedded_setup_chromeos.html
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243213002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/317ba3276ca7bda6433f7f953b17e92640fb258b Cr-Commit-Position: refs/heads/master@{#348631}
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/317ba3276ca7bda6433f7f953b17e92640fb258b Cr-Commit-Position: refs/heads/master@{#348631} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
