Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 12432019: Merge 187643 "Fix views omnibox unfocused double-click behavior." (Closed)

Created:
7 years, 9 months ago by msw
Modified:
7 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Merge 187643 "Fix views omnibox unfocused double-click behavior." > Fix views omnibox unfocused double-click behavior. > > Move the cursor to the double-click event location before selecting the surrounding word. > This fixes double-click behavior when the views omnibox is unfocused. > ( unfocused mouse-up on the first click selects all, changing the cursor position ) > > BUG=131660, 165873 > TEST=double-clicking the unfocused omnibox selects the expected word. > R=sky@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12408023 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
msw
7 years, 9 months ago (2013-03-14 19:25:23 UTC) #1
msw
7 years, 9 months ago (2013-03-14 19:26:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r188158.

Powered by Google App Engine
This is Rietveld 408576698