Issue 12432013: Revert "Add .dir-locals.el."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12432013: Revert "Add .dir-locals.el." (Closed)

Created:
7 years, 9 months ago by Sven Panne

Modified:
7 years, 9 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Add .dir-locals.el." After some discussions, this seems to be the wrong approach. We should probably either link to the Google style guide and its related configuration files, or even add a Makefile target for downloading it. Furthermore, with this change Emacs keeps popping up an annoying confirmation window for new files. Committed: http://code.google.com/p/v8/source/detail?r=13889

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	D	.dir-locals.el	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 9 months ago (2013-03-11 08:16:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13889 (presubmit successful).

Expand Messages | Collapse Messages