Issue 12432005: ES6 symbols: refine test for getOwnPropertyNames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12432005: ES6 symbols: refine test for getOwnPropertyNames (Closed)

Created:
7 years, 9 months ago by rossberg

Modified:
7 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev, adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ES6 symbols: refine test for getOwnPropertyNames R=mstarzinger@chromium.org BUG=v8:2158 Committed: http://code.google.com/p/v8/source/detail?r=13866

Patch Set 2 : Addressed comment #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	test/mjsunit/harmony/symbols.js	View	1	2 chunks	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/12432005/diff/1/test/mjsunit/harmony/symbols.js File test/mjsunit/harmony/symbols.js (right): https://codereview.chromium.org/12432005/diff/1/test/mjsunit/harmony/symbols.js#newcode198 test/mjsunit/harmony/symbols.js:198: var asString = "" + ...

7 years, 9 months ago (2013-03-07 15:39:32 UTC) #2

rossberg

7 years, 9 months ago (2013-03-07 15:43:05 UTC) #3

https://codereview.chromium.org/12432005/diff/1/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):

https://codereview.chromium.org/12432005/diff/1/test/mjsunit/harmony/symbols....
test/mjsunit/harmony/symbols.js:198: var asString = "" + name
On 2013/03/07 15:39:32, Michael Starzinger wrote:
> Using "var asString = String(name);" here is clearer.

Done.

Expand Messages | Collapse Messages

Issue 12432005: ES6 symbols: refine test for getOwnPropertyNames (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages