chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc - Issue 1243173003: [MediaRouter] Moved the code useful for Android to MediaRouterDialogController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

Issue 1243173003: [MediaRouter] Moved the code useful for Android to MediaRouterDialogController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@build-media-router-android

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc ('K') | « chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc ('k') | chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

diff --git a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

index 18733d1f6a27e9edd8c521189edcb15c467a8966..6775e39481a7846a9cfe60e129912c58221616b4 100644

--- a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

+++ b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

@@ -45,7 +45,8 @@ class MediaRouterDialogControllerBrowserTest : public InProcessBrowserTest {

ASSERT_TRUE(dialog_controller_);

// Get the media router dialog for the initiator.

- media_router_dialog_ = dialog_controller_->ShowMediaRouterDialog();

+ dialog_controller_->ShowMediaRouterDialog();

+ media_router_dialog_ = dialog_controller_->GetMediaRouterDialog();

ASSERT_TRUE(media_router_dialog_);

}

@@ -112,7 +113,7 @@ IN_PROC_BROWSER_TEST_F(MediaRouterDialogControllerBrowserTest,

dialog_watcher.Wait();

// Entry has been removed.

- EXPECT_FALSE(dialog_controller_->GetMediaRouterDialog());

+ EXPECT_FALSE(dialog_controller_-> GetMediaRouterDialog());

apacible 2015/07/24 20:41:07 nit: Remove whitespace?

whywhat 2015/07/28 18:52:53 Done.

}

} // namespace media_router