Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 124313005: Revert of Test Keeping NaCl plugins used in app background pages alive when active. (Closed)

Created:
6 years, 11 months ago by ckocagil
Modified:
6 years, 11 months ago
Reviewers:
scheib, yzshen1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -319 lines) Patch
M chrome/browser/extensions/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 5 chunks +0 lines, -126 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +1 line, -5 lines 0 comments Download
M extensions/browser/process_manager.h View 2 chunks +0 lines, -11 lines 0 comments Download
M extensions/browser/process_manager.cc View 3 chunks +1 line, -17 lines 0 comments Download
M ppapi/proxy/plugin_main_nacl.cc View 5 chunks +0 lines, -17 lines 0 comments Download
M ppapi/shared_impl/ppapi_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D ppapi/tests/extensions/background_keepalive/background.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D ppapi/tests/extensions/background_keepalive/background.js View 1 chunk +0 lines, -41 lines 0 comments Download
D ppapi/tests/extensions/background_keepalive/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
M ppapi/tests/extensions/extensions.gyp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ckocagil
Created Revert of Test Keeping NaCl plugins used in app background pages alive when active.
6 years, 11 months ago (2014-01-04 22:29:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/124313005/1
6 years, 11 months ago (2014-01-04 22:29:57 UTC) #2
commit-bot: I haz the power
Change committed as 243034
6 years, 11 months ago (2014-01-04 22:30:13 UTC) #3
scheib
6 years, 11 months ago (2014-01-06 23:11:59 UTC) #4
Message was sent while issue was closed.
Errors:


AppBackgroundPageNaClTest.BackgroundKeepaliveIdle (run #1):
[ RUN      ] AppBackgroundPageNaClTest.BackgroundKeepaliveIdle
[117312:117464:0104/074101:4463921:ERROR:desktop_root_window_host_win.cc(755)]
NOT IMPLEMENTED

Powered by Google App Engine
This is Rietveld 408576698