Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 1243123002: [NaCl SDK] Fix initialization of pthread_t in dlopen example (Closed)

Created:
5 years, 5 months ago by Sam Clegg
Modified:
5 years, 5 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix initialization of pthread_t in dlopen example Initializing a pthread_t to NULL (or any value really) is not valid. This causes a compiler warning with the new arm glibc toolchain so needs to be fixed because we enable the new toolchain. Turns out the pid_ member was not even needed so this change removes it and adds a pthread_detach call which allows for freeing on the thread's resources (in the absence of pthread_join). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk BUG=505885 Committed: https://crrev.com/b1904c3552fd0a572426430462c912efee2e0a98 Cr-Commit-Position: refs/heads/master@{#339720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M native_client_sdk/src/examples/tutorial/dlopen/dlopen.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Sam Clegg
5 years, 5 months ago (2015-07-21 17:04:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243123002/1
5 years, 5 months ago (2015-07-21 17:05:13 UTC) #4
binji
lgtm
5 years, 5 months ago (2015-07-21 17:07:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243123002/1
5 years, 5 months ago (2015-07-21 18:24:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_nacl_sdk on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
5 years, 5 months ago (2015-07-21 19:07:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243123002/1
5 years, 5 months ago (2015-07-21 19:27:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 19:36:42 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:49:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1904c3552fd0a572426430462c912efee2e0a98
Cr-Commit-Position: refs/heads/master@{#339720}

Powered by Google App Engine
This is Rietveld 408576698