Issue 12431018: Increase bits for effect attribute key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12431018: Increase bits for effect attribute key (Closed)

Created:
7 years, 9 months ago by jvanverth1

Modified:
7 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Increase bits for effect attribute key. We can have an attribute index value up to 7, but only allow 2 bits for each index in GrGLEffect::GenAttribKey. This change gives them 3 bits (and fixes an assert when running tests in debug).

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	include/gpu/GrBackendEffectFactory.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/gpu/gl/GrGLEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed as r8140.

Expand Messages | Collapse Messages