Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 12431017: Revert 187554 "Implement IPC::ChannelFactory, a class that accep..." (Closed)

Created:
7 years, 9 months ago by falken
Modified:
7 years, 9 months ago
Reviewers:
jeremya
CC:
chromium-reviews, darin-cc_chromium.org, jam, sail+watch_chromium.org
Visibility:
Public.

Description

Revert 187554 "Implement IPC::ChannelFactory, a class that accep..." Reverting because it seems to cause failures on ipc_tests (UnixDomainSocketUtil.Connect, UnixDomainSocketUtil.SendReceive) on Android. > Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket. > > IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate > when a client connects. The delegate is expected to craft an IPC::Channel from > the handle it is given. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186912 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187233 > > Review URL: https://chromiumcodereview.appspot.com/12386010 TBR=jeremya@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -615 lines) Patch
M ipc/ipc.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
M ipc/ipc.gypi View 3 chunks +1 line, -13 lines 0 comments Download
M ipc/ipc_channel.h View 1 chunk +2 lines, -2 lines 0 comments Download
D ipc/ipc_channel_factory.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ipc/ipc_channel_factory.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M ipc/ipc_channel_posix.h View 2 chunks +7 lines, -1 line 0 comments Download
M ipc/ipc_channel_posix.cc View 7 chunks +170 lines, -13 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ipc/unix_domain_socket_util.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ipc/unix_domain_socket_util.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D ipc/unix_domain_socket_util_unittest.cc View 1 chunk +0 lines, -163 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
7 years, 9 months ago (2013-03-13 03:46:24 UTC) #1
falken
Committed patchset #1 manually as r187760.
7 years, 9 months ago (2013-03-13 03:46:40 UTC) #2
falken
7 years, 9 months ago (2013-03-13 03:47:15 UTC) #3
Message was sent while issue was closed.
On 2013/03/13 03:46:40, falken wrote:
> Committed patchset #1 manually as r187760.

Commented on original review: https://chromiumcodereview.appspot.com/12386010

Powered by Google App Engine
This is Rietveld 408576698