Copies Simulator Debugger from ARM to MIPS.

runtime/vm/constants_mips.h

Index: runtime/vm/constants_mips.h
===================================================================
--- runtime/vm/constants_mips.h	(revision 19885)
+++ runtime/vm/constants_mips.h	(working copy)
@@ -48,12 +48,15 @@
   // Register aliases.
   ZR = R0,
   AT = R1,
+
   V0 = R2,
   V1 = R3,
+
   A0 = R4,
   A1 = R5,
   A2 = R6,
   A3 = R7,
+
   T0 = R8,
   T1 = R9,
   T2 = R10,
@@ -62,17 +65,22 @@
   T5 = R13,
   T6 = R14,
   T7 = R15,
+
   S0 = R16,
   S1 = R17,
-  S3 = R18,
-  S4 = R19,
-  S5 = R20,
-  S6 = R21,
-  S7 = R22,
+  S2 = R18,
+  S3 = R19,
+  S4 = R20,
+  S5 = R21,
+  S6 = R22,
+  S7 = R23,
+
   T8 = R24,
   T9 = R25,
+
   K0 = R26,
   K1 = R27,
+
   GP = R28,
   SP = R29,
   FP = R30,
@@ -159,6 +167,8 @@
   kImmBits = 16,
   kInstrShift = 0,
   kInstrBits = 26,
+  kBreakCodeShift = 5,
+  kBreakCodeBits = 20,
 };
 
 
@@ -295,9 +305,14 @@
 
   // Get the raw instruction bits.
   inline int32_t InstructionBits() const {
-    return reinterpret_cast<int32_t>(this);
+    return *reinterpret_cast<const int32_t*>(this);
   }
 
+  // Set the raw instruction bits to value.
+  inline void SetInstructionBits(int32_t value) {
+    *reinterpret_cast<int32_t*>(this) = value;
+  }
+
   // Read one particular bit out of the instruction bits.
   inline int32_t Bit(int nr) const {
     return (InstructionBits() >> nr) & 1;
@@ -338,17 +353,23 @@
     return (Bits(kImmShift, kImmBits) << (32 - kImmBits)) >> (32 - kImmBits);
   }
 
+  inline int32_t BreakCodeField() const {
+    return Bits(kBreakCodeShift, kBreakCodeBits);
+  }
+
   inline SpecialFunction FunctionField() const {
     return static_cast<SpecialFunction>(Bits(kFunctionShift, kFunctionBits));
   }
 
+  inline bool IsBreakPoint() {
+    return (InstructionBits() == kBreakPointInstruction);

[regis, 2013/03/12 20:53:19]

You should mask the code and not require the code to be zero.
But we have to be careful with a simulator redirection, which may use a specific
code. Unless you plan on using another instruction? SYSCALL maybe?

[zra, 2013/03/13 18:09:14]

Done.

+  }
+
   // Instructions are read out of a code stream. The only way to get a
   // reference to an instruction is to convert a pc. There is no way
   // to allocate or create instances of class Instr.
   // Use the At(pc) function to create references to Instr.
-  static Instr* At(uword pc) {
-    return reinterpret_cast<Instr*>(*reinterpret_cast<int32_t*>(pc));
-  }
+  static Instr* At(uword pc) { return reinterpret_cast<Instr*>(pc); }
 
  private:
   DISALLOW_ALLOCATION();