content/browser/devtools/render_view_devtools_agent_host.cc - Issue 12431011: Avoid retaining the pointer to inspected WebContents in DevToolsWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_view_devtools_agent_host.cc

Issue 12431011: Avoid retaining the pointer to inspected WebContents in DevToolsWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/render_view_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_view_devtools_agent_host.cc b/content/browser/devtools/render_view_devtools_agent_host.cc

index 6bbb10315e691b85ee8bf0ec1071939484b71f99..5fe5ff75eacf0250cfaa68efe066a7279f851614 100644

--- a/content/browser/devtools/render_view_devtools_agent_host.cc

+++ b/content/browser/devtools/render_view_devtools_agent_host.cc

@@ -198,6 +198,8 @@ void RenderViewDevToolsAgentHost::DispatchOnInspectorBackend(

}

void RenderViewDevToolsAgentHost::SendMessageToAgent(IPC::Message* msg) {

+ if (!render_view_host_)

+ return;

msg->set_routing_id(render_view_host_->GetRoutingID());

render_view_host_->Send(msg);

}

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | no next file » | no next file with comments »