Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 12431011: Avoid retaining the pointer to inspected WebContents in DevToolsWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index 8d8141eee16cfb3d5faf9f17d9ff6e14b44b75e3..3d7b2d1f8bce0d7cc684a399048d76add4c6e589 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -111,14 +111,14 @@ class DevToolsWindow : private content::NotificationObserver,
private:
friend class DevToolsControllerTest;
static DevToolsWindow* Create(Profile* profile,
- content::RenderViewHost* inspected_rvh,
DevToolsDockSide dock_side,
bool shared_worker_frontend);
DevToolsWindow(content::WebContents* web_contents,
Profile* profile,
- content::RenderViewHost* inspected_rvh,
DevToolsDockSide dock_side);
+ content::WebContents* GetInspectedWebContents();
+
void CreateDevToolsBrowser();
bool FindInspectedBrowserAndTabIndex(Browser**, int* tab);
BrowserWindow* GetInspectedBrowserWindow();
@@ -199,7 +199,6 @@ class DevToolsWindow : private content::NotificationObserver,
static DevToolsDockSide SideFromString(const std::string& dock_side);
Profile* profile_;
- content::WebContents* inspected_web_contents_;
content::WebContents* web_contents_;
Browser* browser_;
DevToolsDockSide dock_side_;
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | chrome/browser/devtools/devtools_window.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698