Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1243043002: Implement Atk Component interface 'grab_focus' for Chrome UI

Created:
5 years, 5 months ago by shreeramk
Modified:
5 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Atk Component interface 'grab_focus' for Chrome UI This CL implements 'grab_focus' interface in Atk component. BUG=463671

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
shreeramk
PTAL. Thanks.
5 years, 5 months ago (2015-07-21 06:30:32 UTC) #2
dmazzoni
https://codereview.chromium.org/1243043002/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc File ui/accessibility/platform/ax_platform_node_auralinux.cc (right): https://codereview.chromium.org/1243043002/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc#newcode271 ui/accessibility/platform/ax_platform_node_auralinux.cc:271: return atk_component_grab_focus(atk_component); You're implementing atk_component_grab_focus for our component, by ...
5 years, 5 months ago (2015-07-21 15:49:01 UTC) #3
shreeramk
5 years, 5 months ago (2015-07-23 06:16:42 UTC) #4 
On 2015/07/21 15:49:01, dmazzoni wrote:
>
https://codereview.chromium.org/1243043002/diff/1/ui/accessibility/platform/a...
> File ui/accessibility/platform/ax_platform_node_auralinux.cc (right):
> 
>
https://codereview.chromium.org/1243043002/diff/1/ui/accessibility/platform/a...
> ui/accessibility/platform/ax_platform_node_auralinux.cc:271: return
> atk_component_grab_focus(atk_component);
> You're implementing atk_component_grab_focus for our component, by calling
> atk_component_grab_focus, I think this will just result in an endless loop.
> 
> You need to add a new API to AXPlatformNodeDelegate to set focus.

I think I confused it. I ll add a new API to set and get focus.

Powered by Google App Engine
This is Rietveld 408576698