Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 124303002: Layout support for new ellipse shape syntax (Closed)

Created:
6 years, 11 months ago by rwlbuis
Modified:
6 years, 11 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), zoltan1, eae+blinkwatch, leviw+renderwatch, dstockwell, Timothy Loh, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Layout support for new ellipse shape syntax Implement support for doing layout with the new ellipse shape syntax, including basic animation support. Add a test for the new ellipse syntax. The old tests in LayoutTests/csswg will be removed when the old syntax is removed. Also update existing shape-inside, animation, and clip-path tests to test the new syntax. BUG=322165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164901

Patch Set 1 #

Patch Set 2 : Rebase against ToT #

Patch Set 3 : Fix test expectation #

Patch Set 4 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -86 lines) Patch
M LayoutTests/animations/interpolation/shape-outside.html View 1 2 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/animations/interpolation/shape-outside-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/css3/masking/clip-path-animation.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/css3/masking/clip-path-animation-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/masking/clip-path-ellipse.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-animation-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse-padding.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-empty-expected.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000-expected.html View 4 chunks +7 lines, -13 lines 0 comments Download
M LayoutTests/virtual/legacy-animations-engine/animations/interpolation/shape-outside-expected.txt View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/rendering/shapes/Shape.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/rendering/style/BasicShapes.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/style/BasicShapes.cpp View 1 2 chunks +27 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bem Jones-Bey (adobe)
lgtm
6 years, 11 months ago (2014-01-03 22:48:39 UTC) #1
rwlbuis
This is very similar to https://codereview.chromium.org/115253003/
6 years, 11 months ago (2014-01-09 21:16:27 UTC) #2
rwlbuis
On 2014/01/09 21:16:27, rwlbuis wrote: > This is very similar to https://codereview.chromium.org/115253003/ Bots are green ...
6 years, 11 months ago (2014-01-10 19:01:04 UTC) #3
leviw_travelin_and_unemployed
lgtm
6 years, 11 months ago (2014-01-10 19:09:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/124303002/180001
6 years, 11 months ago (2014-01-10 19:09:52 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 20:47:16 UTC) #6
Message was sent while issue was closed.
Change committed as 164901

Powered by Google App Engine
This is Rietveld 408576698