Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 12430013: Fix panel showing logic when Chrome enters the fullscreen mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix mac test Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index 1372b935691264b3a883c3a52e4256dd2035b633..294f54684909695ddc6f79fbce3ac7cbcdd6a985 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -258,9 +258,6 @@ gfx::Rect Panel::GetBounds() const {
}
void Panel::Show() {
- if (manager()->display_settings_provider()->is_full_screen() || !collection_)
- return;
-
native_panel_->ShowPanel();
}
@@ -269,6 +266,8 @@ void Panel::Hide() {
}
void Panel::ShowInactive() {
+ // Only if the panel is created without initial focus, we delay its showing
Dmitry Titov 2013/03/14 01:10:25 The description of the bug repeats this statement,
jianli 2013/03/14 19:11:48 Removed this comment and put back the removed code
+ // until the fullscreen mode is exited.
if (manager()->display_settings_provider()->is_full_screen() || !collection_)
return;

Powered by Google App Engine
This is Rietveld 408576698