Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/browser/ui/cocoa/panels/panel_cocoa.mm

Issue 12430013: Fix panel showing logic when Chrome enters the fullscreen mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix mac test Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/panels/panel_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/panels/panel_cocoa.mm b/chrome/browser/ui/cocoa/panels/panel_cocoa.mm
index 722d88ed24bbe7f2db2ddfa78a63d2fc9319d6c8..453fcab328279fcb890e36881914a0e82bcaa32e 100644
--- a/chrome/browser/ui/cocoa/panels/panel_cocoa.mm
+++ b/chrome/browser/ui/cocoa/panels/panel_cocoa.mm
@@ -210,8 +210,18 @@ void PanelCocoa::HandlePanelKeyboardEvent(
[event_window redispatchKeyEvent:event.os_event];
}
-void PanelCocoa::FullScreenModeChanged(
- bool is_full_screen) {
+void PanelCocoa::FullScreenModeChanged(bool is_full_screen) {
+ if (!is_shown_) {
+ // If the panel window is not shown due to that a Chrome tab window is in
+ // fullscreen mode when the panel is being created, we need to show the
+ // panel window now. In addition, its titlebar needs to be updated since it
+ // is not done at the panel creation time.
+ if (!is_full_screen) {
+ ShowPanelInactive();
+ UpdatePanelTitleBar();
+ }
+ return;
Dmitry Titov 2013/03/14 01:10:25 why this return? don't we need to do the controlle
jianli 2013/03/14 19:11:48 No, we do not need the call. If the panel window h
+ }
[controller_ fullScreenModeChanged:is_full_screen];
}

Powered by Google App Engine
This is Rietveld 408576698