Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1242973002: [d8] Remove deprecated calls from d8-readline (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Remove deprecated calls from d8-readline R=jochen@chromium.org LOG=n Committed: https://crrev.com/5e5fadb71c9dc86c8278cc66d826e19d18e1a203 Cr-Commit-Position: refs/heads/master@{#29767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M src/d8-readline.cc View 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
5 years, 5 months ago (2015-07-20 23:01:01 UTC) #1
adamk
lgtm Was about to upload this patch myself, thanks!
5 years, 5 months ago (2015-07-21 03:05:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242973002/1
5 years, 5 months ago (2015-07-21 03:27:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 03:28:42 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 03:28:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e5fadb71c9dc86c8278cc66d826e19d18e1a203
Cr-Commit-Position: refs/heads/master@{#29767}

Powered by Google App Engine
This is Rietveld 408576698