Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 1242943010: Don't use "=>" for void methods in delegates. (Closed)

Created:
4 years, 1 month ago by nweiz
Modified:
4 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use "=>" for void methods in delegates. "=>" breaks if the delegate wraps a subclass that adds a return type (e.g. DelegatingSink wrapping a StreamSink). R=rnystrom@google.com Committed: https://github.com/dart-lang/async/commit/dda644888c90f39e79029450d8f3bcdb565ea0b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M lib/src/delegate/event_sink.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M lib/src/delegate/sink.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M lib/src/delegate/stream_sink.dart View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 1 month ago (2015-07-23 00:51:31 UTC) #2
Bob Nystrom
lgtm
4 years, 1 month ago (2015-07-23 17:47:18 UTC) #3
nweiz
4 years, 1 month ago (2015-07-23 18:10:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dda644888c90f39e79029450d8f3bcdb565ea0b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698