Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tools/telemetry/telemetry/internal/platform/mac_platform_backend.py

Issue 1242943005: [Android] Support idle wakeup measurement with /proc/timer_stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Working test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/platform/mac_platform_backend.py
diff --git a/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py b/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py
index 342e5c66c80e850c6c4e10c1abfb1d19cd35b714..a23864fffeb2e082f7cb23bf8f0dc1dddaab0a72 100644
--- a/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py
+++ b/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py
@@ -89,8 +89,7 @@ class MacPlatformBackend(posix_platform_backend.PosixPlatformBackend):
results = {'CpuProcessTime': cpu_time,
'ContextSwitches': proc_info.pti_csw}
- # top only reports idle wakeup count starting from OS X 10.9.
- if self.GetOSVersionName() >= os_version_module.MAVERICKS:
+ if self.CanMeasureIdleWakeUps():
results.update({'IdleWakeupCount': self._GetIdleWakeupCount(pid)})
return results
@@ -161,6 +160,10 @@ class MacPlatformBackend(posix_platform_backend.PosixPlatformBackend):
def CanMonitorPower(self):
return self._power_monitor.CanMonitorPower()
+ def CanMeasureIdleWakeUps(self):
+ # top only reports idle wakeup count starting from OS X 10.9.
+ return self.GetOSVersionName() >= os_version_module.MAVERICKS
+
def CanMeasurePerApplicationPower(self):
return self._power_monitor.CanMeasurePerApplicationPower()
@@ -169,3 +172,11 @@ class MacPlatformBackend(posix_platform_backend.PosixPlatformBackend):
def StopMonitoringPower(self):
return self._power_monitor.StopMonitoringPower()
+
+ def StartMeasuringIdleWakeUps(self):
+ """Do nothing. The idle wake up numbers come from top."""
+ pass
+
+ def StopMeasuringIdleWakeUps(self):
+ """Do nothing. The idle wake up numbers come from top."""
+ pass

Powered by Google App Engine
This is Rietveld 408576698